Re: [PATCH 02/27] drm/bridge: ps8622: #include <linux/gpio/consumer.h>, depend on GPIOLIB

[Thierry Reding]

On Tue, May 05, 2015 at 06:32:18PM +0200, Geert Uytterhoeven wrote:
> If GPIOLIB=n and asm-generic/gpio.h is not used:
> 
>     drivers/gpu/drm/bridge/ps8622.c: In function âps8622_pre_enableâ:
>     drivers/gpu/drm/bridge/ps8622.c:368: error: implicit declaration of function âgpiod_set_valueâ
>     drivers/gpu/drm/bridge/ps8622.c: In function âps8622_probeâ:
>     drivers/gpu/drm/bridge/ps8622.c:584: error: implicit declaration of function âdevm_gpiod_getâ
>     drivers/gpu/drm/bridge/ps8622.c:584: warning: assignment makes pointer from integer without a cast
>     drivers/gpu/drm/bridge/ps8622.c:590: error: implicit declaration of function âgpiod_direction_outputâ
>     drivers/gpu/drm/bridge/ps8622.c:596: warning: assignment makes pointer from integer without a cast
> 
> Add the missing #include <linux/gpio/consumer.h> to fix this.
> 
> As the resulting driver won't work with GPIOLIB=n anyway, make
> DRM_PS8622 depend on GPIOLIB || COMPILE_TEST.
> 
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> ---
>  drivers/gpu/drm/bridge/Kconfig  | 4 ++--
>  drivers/gpu/drm/bridge/ps8622.c | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)

Applied, thanks. With the same modifications as patch 1/27. I wonder if
there's any reason to keep the linux/gpio.h include, since consumer.h
seems to expose all the API that the drivers need.

Thierry

Attachment: pgpgiwfxI4cBq.pgp
Description: PGP signature