Re: [PATCHv3] perf stat: Add id into perf_stat struct

From: Arnaldo Carvalho de Melo
Date: Mon Jun 08 2015 - 10:04:09 EST


Em Thu, Jun 04, 2015 at 03:50:55PM +0200, Jiri Olsa escreveu:
> On Wed, Jun 03, 2015 at 04:25:51PM +0200, Jiri Olsa wrote:
> > We need fast way to identify evsel as transaction event
> > for shadow counters computation. Currently we are using
> > possition (in evlist) based way.
> >
> > Adding 'id' into 'struct perf_stat' so it can carry transaction
> > event ID and we can use it for shadow counters computations.
> >
> > Link: http://lkml.kernel.org/n/tip-9lnvjksibrs0flhkpix2qkm9@xxxxxxxxxxxxxx
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> > ---
>
> using perf_evsel__name instead of evsel->name pointer

It now passes 'perf test' on rhel7/fedora21 systems, but it fails on a
rhel6 system, I applied it, will test it further on the rhel6 system to
see what went wrong there, unless you do it first ;-)

[root@sandy ~]# perf test 15
15: struct perf_event_attr setup :sh: line
1: 5381 Aborted (core dumped)
PERF_TEST_ATTR=/tmp/tmp8ZBLwc /home/acme/bin/perf stat -o
/tmp/tmp8ZBLwc/perf.data --group -e cycles,instructions kill > /dev/null
2>&1
sh: line 1: 5438 Aborted (core dumped)
PERF_TEST_ATTR=/tmp/tmpnRDADB /home/acme/bin/perf stat -o
/tmp/tmpnRDADB/perf.data -e '{cycles,instructions}' kill > /dev/null
2>&1
Ok
[root@sandy ~]# uname -r
2.6.32-504.8.1.el6.x86_64
[root@sandy ~]# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 6.6 (Santiago)
[root@sandy ~]#

- Arnaldo


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/