Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

From: Bhuvanchandra DV
Date: Tue Jun 09 2015 - 00:13:17 EST


On 06/08/2015 02:42 PM, Russell King - ARM Linux wrote:
On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote:
+ /*
+ * CTS/RTS can _only_ be handled
+ * automatically by the hardware.
+ */

That's really not acceptable. You need to do something here so that you
can _force_ RTS to be deasserted when the kernel buffers fill up - be
that by stopping reading characters and letting the FIFO fill up or
something of that ilk.
Agreed, will fix this.

Ignoring the rest of the flow control system in the kernel is not really
acceptable.


Best regards,
Bhuvan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/