Re: [PATCH v5 4/6] i2c: at91: add support for new alternative command mode

From: Wolfram Sang
Date: Tue Jun 09 2015 - 18:20:01 EST


Nicolas,

> > +static struct at91_twi_pdata at91sama5d2_config = {
>
> No, please name it:
>
> "sama5d2_config"

Thanks for your input, but please don't quote the whole mail for those
tiny comments. Only the relevant parts, please. Otherwise it is too easy
to miss things.

Thanks,

Wolfram

Attachment: signature.asc
Description: Digital signature