Re: [PATCH] Input: goodix - do not explicitly set evbits in input device

From: Bastien Nocera
Date: Wed Jun 10 2015 - 11:08:56 EST


On Wed, 2015-06-10 at 10:39 -0400, Benjamin Tissoires wrote:
> On Jun 10 2015 or thereabouts, Bastien Nocera wrote:
> > On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote:
> > > input_mt_init_slots() will do that for us.
> >
> > I'm guessing you know what you're doing here, but I couldn't find
> > where
> > the EV_SYN bit would have been set in the input_mt_init_slots()
> > call
> > chain.
>
> input_register_device() sets EV_SYN bit for us (it is a mandatory
> field
> for input).
<snip>
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

OK, thanks for the explanation.

Acked-by: Bastien Nocera <hadess@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/