Re: [PATCH 1/1] staging: lustre/lustre/llite: get rid of incorrect type warning

From: Tolga Ceylan
Date: Thu Jun 11 2015 - 04:08:47 EST


On Wed, Jun 10, 2015 at 5:48 PM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> Are you sure all of these are correct? The kernel/user api for lustre
> is a complex beast, and just casting away the pointer types isn't
> usually the proper thing to do in order to resolve the issues here.
>
> thanks,
>
> greg k-h

I'm not 100% sure, but the pointers that I added the annotation to end
up being used as user memory. (eg. passed to copy_to_user, etc.)
Sometimes these pointers are passed to functions that already have
__user annotation in their signatures (eg. ll_getname, copy_and_ioctl,
ll_fid2path, etc.).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/