Re: [PATCH v2] ARM: zynq: Fix earlyprintk in big endian mode

From: Michal Simek
Date: Fri Jun 12 2015 - 05:25:38 EST


On 06/12/2015 08:53 AM, Arun Chandran wrote:
> earlyprintk messages are not appearing on the terminal
> emulator during a big endian kernel boot. In BE mode
> sending full words to UART will result in unprintable
> characters as they are byte swapped versions of printable
> ones. So send only bytes.
>
> Signed-off-by: Arun Chandran <achandran@xxxxxxxxxx>
> ---
> ---
> Changes since v1:
> removed the byte swapping logic. Just send characters instead.
> ---
> arch/arm/include/debug/zynq.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/debug/zynq.S b/arch/arm/include/debug/zynq.S
> index bd13ded..de86b92 100644
> --- a/arch/arm/include/debug/zynq.S
> +++ b/arch/arm/include/debug/zynq.S
> @@ -38,7 +38,7 @@
> .endm
>
> .macro senduart,rd,rx
> - str \rd, [\rx, #UART_FIFO_OFFSET] @ TXDATA
> + strb \rd, [\rx, #UART_FIFO_OFFSET] @ TXDATA
> .endm
>
> .macro waituart,rd,rx
>

ok - this works too.

Tested-by: Michal Simek <michal.simek@xxxxxxxxxx>

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/