Re: [PATCH] i2c: designware: use enable on resume instead initialization

[Lucas De Marchi]

Hi Mika,

On Wed, Jun 10, 2015 at 4:55 AM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Mon, Jun 08, 2015 at 02:50:28PM -0300, lucas.de.marchi@xxxxxxxxx wrote:
>> @@ -320,7 +320,7 @@ static int dw_i2c_resume(struct device *dev)
>>       clk_prepare_enable(i_dev->clk);
>>
>>       if (!i_dev->pm_runtime_disabled)
>> -             i2c_dw_init(i_dev);
>> +             i2c_dw_enable(i_dev);
>
> This will not work if the device power gets removed (for example being
> put to D3cold) as it looses context.

Do you mean we should keep the i2c_dw_init() here?

-- 
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/