Re: [PATCH v5 1/2] x86, mwaitt: add monitorx and mwaitx instruction

[Huang Rui]

On Mon, Jun 15, 2015 at 12:55:42PM +0200, Peter Zijlstra wrote:
> On Mon, Jun 15, 2015 at 06:48:03PM +0800, Huang Rui wrote:
> > +/*
> > + * MWAITT allows for both a timer value to get you out of the MWAIT as
> > + * well as the normal exit conditions.
> > + *
> > + * MWAITX ECX[1]: enable timer if set
> > + * MWAITX EBX[31:0]: max wait time expressed in SW P0 clocks
> > + *
> > + * Below is the compared data between MWAIT and MWAITX on AMD
> > + * processors:
> > + *                 MWAIT                           MWAITX
> > + * opcode          0f 01 c9           |            0f 01 fb
> > + * ECX[0]                  value of RFLAGS.IF seen by instruction
> > + * ECX[1]          unused/#GP if set  |            enable timer if set
> > + * ECX[31:2]                     unused/#GP if set
> > + * EAX                           unused (reserve for hint)
> 
> Seeing how you're stuffing a !0 value in here in the next patch, the
> above comment seems slightly incorrect, no?
> 

That's because current processor doesn't support to go C1 state.
The next patch use the hint is to avoid core go to C1 state in future
processor.

Thanks,
Rui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/