Re: [PATCH] Staging: wilc1000: Boolean tests don't need comparisons
From: Abdul, Hussain (H.)
Date: Tue Jun 16 2015 - 04:55:31 EST
On Tuesday 16 June 2015 01:40 PM, Sudip Mukherjee wrote:
> On Tue, Jun 16, 2015 at 07:33:42AM +0000, Abdul, Hussain (H.) wrote:
>> From: Abdul Hussain <habdul@xxxxxxxxxxx>
>> This patch removes unwanted true and false from boolean tests.
>> Signed-off-by: Abdul Hussain <habdul@xxxxxxxxxxx>
>> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
>> index 17ab5cd..be1f6bf 100644
>> --- a/drivers/staging/wilc1000/host_interface.c
>> +++ b/drivers/staging/wilc1000/host_interface.c
>> @@ -7816,7 +7816,7 @@ static void *host_int_ParseJoinBssParam(tstrNetworkInfo *ptstrNetworkInfo)
>> pNewJoinBssParam->rsn_cap = pu8IEs[rsnIndex + 1];
>> rsnIndex += 2;
>> - pNewJoinBssParam->rsn_found = 1;
>> + pNewJoinBssParam->rsn_found = true;
> But this is not a boolean test, this is an assignement.
Yes that is an assignment to the boolean variable. Do i need to modify the commit message or to send separate patch?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/