Re: [PATCH RFC v7 2/3] crypto: rsa: add a new rsa generic implementation

From: Herbert Xu
Date: Tue Jun 16 2015 - 22:37:05 EST

On Tue, Jun 16, 2015 at 07:32:16PM -0700, Tadeusz Struk wrote:
> I thought that -EBADMSG was mainly used for authenticated ciphers in case when verification of auth data fails.
> Since this are input params I thought that -EINVAL would be more appropriate.
> I can change it to -EBADMSG, no problem.
> Herbert, what do you think?

The existing crypto/asymmetric_key errno scheme doesn't really
mesh in with the rest of crypto. So you'll just have to pick one
scheme and stick with it.

I don't really mind either way as long as the error codes are
unique and meaningful.

Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at