Re: [PATCH] staging: wilc1000: remove WILC_WFIDrvHandle

From: Greg Kroah-Hartman
Date: Wed Jun 17 2015 - 10:03:25 EST


On Wed, Jun 17, 2015 at 06:46:20PM +0530, Sudip Mukherjee wrote:
> WILC_WFIDrvHandle was:
>
> typedef struct {
> s32 s32Dummy;
> } *WILC_WFIDrvHandle;
>
> which basically meant a pointer to an integer.
> so removed the typedef and replaced all WILC_WFIDrvHandle with int *
>
> Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> ---
>
> replacement was done by using sed, just manually removed the typedef.
> build ok, before this change total 77 build warning, after this patch
> same number of warnings.

Which means this is not the correct fix for this :)

The driver is obviously broken for 64bit systems, and these warnings are
showing that, let's fix this "correctly" please.

sorry, I'm not going to take this patch.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/