Re: [PATCH] perf annotate: With --show-total-period, display total # of samples.

From: Martin LiÅka
Date: Thu Jun 18 2015 - 14:06:38 EST


This is a multi-part message in MIME format.On 06/18/2015 06:26 PM, Ingo Molnar wrote:
>
> * Martin LiÅka <mliska@xxxxxxx> wrote:
>
>> To compare two records on an instruction base, with --show-total-period
>> option provided, display total number of samples that belong to a line
>> in assembly language.
>>
>> Signed-off-by: Martin Liska <mliska@xxxxxxx>
>> ---
>> tools/perf/builtin-annotate.c | 2 ++
>> tools/perf/ui/browsers/annotate.c | 44 +++++++++++++++++++++++++--------------
>> tools/perf/util/annotate.c | 28 +++++++++++++++++++------
>> tools/perf/util/annotate.h | 3 ++-
>> 4 files changed, 54 insertions(+), 23 deletions(-)
>>
>> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
>> index 4e08c2d..2c1bec3 100644
>> --- a/tools/perf/builtin-annotate.c
>> +++ b/tools/perf/builtin-annotate.c
>> @@ -329,6 +329,8 @@ int cmd_annotate(int argc, const char **argv, const char *prefix __maybe_unused)
>> "objdump binary to use for disassembly and annotations"),
>> OPT_BOOLEAN(0, "group", &symbol_conf.event_group,
>> "Show event group information together"),
>> + OPT_BOOLEAN(0, "show-total-period", &symbol_conf.show_total_period,
>> + "Show a column with the sum of periods"),
>> OPT_END()
>
> What is the toggle for this in the 'perf report' TUI? (which displays annotated
> output too)
>
> Thanks,
>
> Ingo
>

Hello.

Thanks for note, I fixed that by introducing a new 't' hot key.

Thanks,
Martin