[RFC] hotkey for disabling/enabling events in 'perf top' TUI was Re: [GIT PULL 0/8] perf/core improvements and fixes

From: Arnaldo Carvalho de Melo
Date: Thu Jun 18 2015 - 16:18:46 EST

Em Thu, Jun 18, 2015 at 09:40:10AM +0200, Ingo Molnar escreveu:
> * Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> > User visible:

> > - Allow disabling/enabling events dynamicly in 'perf top':
> > a 'perf top' session can instantly become a 'perf report'
> > one, i.e. going from dynamic analysis to a static one,
> > returning to a dynamic one is possible, to toogle the
> > modes, just press CTRL+z. (Arnaldo Carvalho de Melo)

> Nice!! :-)

> Btw., it would be nice if the status line carried information about whether
> collection is 'frozen' or running, at a glance. A hint might also suggest how to
> unfreeze the session - in case someone pressed Ctrl-Z to suspend the perf top
> session ...

Right, and I think we better find other hotkey and make Ctrl+Z work like
with other tools, i.e. suspend:

[acme@zoo linux]$ mutt

[1]+ Stopped mutt
[acme@zoo linux]$ vim

[2]+ Stopped vim
[acme@zoo linux]$

The perf TUI should work like that as well...


We already have:

h/?/F1 Show this window
q/ESC/CTRL+C Exit browser

For multiple event sessions:

TAB/UNTAB Switch events

For symbolic views (--sort has sym):

-> Zoom into DSO/Threads & Annotate current symbol
<- Zoom out
a Annotate current symbol
C Collapse all callchains
d Zoom into current DSO
D Show some developer debug info
E Expand all callchains
F Toggle percentage of filtered entries
H Display column headers
i Show header information
P Print histograms to perf.hist.N
r Run available scripts
s Switch to another data file in PWD
t Zoom into current Thread
V Verbose (DSO names in callchains, etc)
z Toggle zeroing of samples
/ Filter symbol by name

> Also, there's now a GUI inconsistency with perf report: which will now exit on
> Ctrl-Z. It should probably print a warning in the status line instead, that
> freezing/unfreezing only works in 'perf top'.

I'll fix that.

- Arnaldo
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/