Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod
From: Chanwoo Choi
Date: Fri Jun 19 2015 - 04:39:34 EST
On Fri, Jun 19, 2015 at 5:14 PM, Charles Keepax
> On Fri, Jun 19, 2015 at 11:36:47AM +0900, Chanwoo Choi wrote:
>> Hi Charles,
>> On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax
>> <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>> > Convert to using the newer gpiod interface for the micd_pol_gpio.
>> > Although we still carry support for the old gpio interface from pdata.
>> > Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
>> > ---
>> > + mode = GPIOD_OUT_HIGH;
>> > + else
>> > + mode = GPIOD_OUT_LOW;
>> > +
>> > + info->micd_pol_gpio = gpiod_get_optional(arizona->dev,
>> > + "wlf,micd-pol",
>> > + GPIOD_OUT_LOW);
>> You can use the devm_gpiod_get_optional() to manage the system
>> resource automatically.
> We can't actually use the devm call here, we need to pass
> arizona->dev as that is where the DT will reside, which is the
> device for the MFD. But if the devm is attached to the device for
> the MFD then it will not clear up when the extcon driver is
> unloaded. As such we have to do the put manually.
> I will look at respinning for the other comments.
I don't understand. extcon-arizona.c used already following devm_* functions:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/