Re: [PATCH v2 5/9] staging: sm7xxfb: fix alignment

From: Dan Carpenter
Date: Fri Jun 19 2015 - 10:45:44 EST


On Wed, Jun 17, 2015 at 04:54:44PM +0530, Sudip Mukherjee wrote:
> @@ -346,9 +346,8 @@ static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, size_t
> dst = buffer;
> for (i = c >> 2; i--;) {
> *dst = fb_readl(src++);
> - *dst =
> - (*dst & 0xff00ff00 >> 8) |
> - (*dst & 0x00ff00ff << 8);
> + *dst = (*dst & 0xff00ff00 >> 8) |
> + (*dst & 0x00ff00ff << 8);

This is supposed to convert __le16 to __be16?

> dst++;
> }
> if (c & 3) {

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/