Re: [PATCH 04/15] libnvdimm, nfit, nd_blk: driver for BLK-mode access persistent memory

From: Christoph Hellwig
Date: Sun Jun 21 2015 - 09:56:23 EST

On Sun, Jun 21, 2015 at 06:31:38AM -0700, Dan Williams wrote:
> > As mentioned last time only arch asm/ headers may include asm-generic
> > headers.
> No, not in this case, there's no other way to define readq()/writeq()
> on 32-bit builds. See:

Oh my god. I think we're both right: no driver should use asm-generic,
but because someone totally messed this abstraction up you have no choice.

We really should have a linux/*.h header for these that just does the
right thing.

Btw, what's the reason you're using the hi-lo ordering unlikely everyone
else? IMHO that should be an arch and not a driver choice.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at