RE: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge

From: Opensource [Adam Thomson]
Date: Mon Jun 22 2015 - 06:24:54 EST


On June 19, 2015 17:48, Paul Bolle wrote:

> On Thu, 2015-06-18 at 17:06 +0100, Adam Thomson wrote:
> > --- /dev/null
> > +++ b/include/linux/mfd/da9150/fg.h
>
> > +/*
> > + * Function template to provide battery temperature. Should provide
> > + * 0.1 degrees C resolution return values.
> > + */
> > +typedef int (*da9150_read_temp_t)(void *context);
> > +
> > +/* Register temp callback function */
> > +void da9150_fg_register_temp_cb(struct power_supply *psy,
> da9150_read_temp_t cb,
> > + void *cb_context);
>
> The pedant in me noticed that this function is actually added in 3/4. So
> this chunk might be moved to 3/4, if you like to entertain pedantry like
> that, that is. (But see my remark on 3/4 too.)

This is true, but as the header is part of MFD, I included it as part of that
patch as I thought this made more sense. I guess Lee will comment as to whether
that was correct or not. :)