Re: [PATCH] fs: inotify: systemd needs it so make it depend on CONFIG_EMBEDDED

From: Austin S Hemmelgarn
Date: Mon Jun 22 2015 - 08:21:15 EST

On 2015-06-19 17:48, Dave Hansen wrote:
On 06/19/2015 11:18 AM, Ilia Mirkin wrote:
Is systemd depending on something really reason enough to make it
depend on EMBEDDED? For example all the cgroups stuff is not only not
dependent on embedded, but also off by default, and I'm sure there are
a boatload of other dependencies which any normal system has no
business worrying about but that are required by systemd.

Does the lack of cgroups keep a (normal) system from booting, though?
Define 'normal'. Just because userspace software depends on something doesn't mean we should force that on everyone, even if disabling it could make some systems fail to boot (that is an inherent risk in building your own kernel). dnotify (inotify's predecessor) is an excellent example of this: nfs-utils depends on it, and that not working can definitely make a system fail to boot, yet it is not hidden behind some other config option, but defaults to being on.

Making inotify default to on (like dnotify) is a better solution to this, anyone who is going around turning off options that default to on in kconfig should be prepared to deal with a system that doesn't boot anyway, and EMBEDDED is intended (AFAICT) for saving space on systems with limited memory, not hiding userspace dependencies that have other legitimate reasons to be disabled.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature