Re: [PATCH] perf annotate: With --show-total-period, display total # of samples.

From: Arnaldo Carvalho de Melo
Date: Mon Jun 22 2015 - 10:38:39 EST

Em Sat, Jun 20, 2015 at 01:53:47PM +0200, Martin LiÅka escreveu:
> On 06/19/2015 09:10 PM, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Jun 19, 2015 at 11:35:41AM +0200, Martin LiÅka escreveu:
> >> Thank you for the review, all remarks were reasonable.
> >> Feel free to comment next version (v3) of the patch.

> > Thanks, there was just one missing s/tuples/samples/g, I did it and
> > tried running git-am on the attached patch, it failed, so I applied it
> > manually.

> Thank you for help, as I followed the documentation related to Thunderbird,
> all spaces and tabs should gone. I still suspect that's culprit of the failure?

Sometimes it is tricky to figure out exactly what went wrong, so I
rather applied it by hand and just dropped a note, but my workflow, when
submitting patches is:

$ git format-patch -n --cover-letter tip/perf/core..
# edit 0000-cover-letter.txt
$ smi 0*

Where smi is:

$ cat ~/bin/smi
git send-email --from "Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>" \
--to "Ingo Molnar <mingo@xxxxxxxxxx>" \
--cc linux-kernel@xxxxxxxxxxxxxxx --no-chain-reply-to $*

Which I guess is what most contributors do, at least the ones I manage
to use 'git am' on their patches, etc.

I.e. no MUA involved, but of course a MUA can be used, just make sure
that you can use git am on the message you first send to yourself, i.e.
that you try replicating the upstream workflow when trying to apply your
patches :-)

- Arnaldo
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at