Re: [PATCH v2 03/14] notifiers: Assert that RCU is watching in notify_die

From: Andy Lutomirski
Date: Mon Jun 22 2015 - 13:04:00 EST


On Mon, Jun 22, 2015 at 9:33 AM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Mon, Jun 22, 2015 at 09:26:13AM -0700, Andy Lutomirski wrote:
>> notify_die is misnamed and has little to do with death. It's really
>> just notifying about an exception, and we might end up oopsing,
>> sending a signal, or neither.
>
> But if we oops and wedge solid afterwards, it might happen that only the
> first splat comes out on the console, no? And that will be the lockdep
> splat which would be useless for debugging the actual problem...
>

The rcu_lockdep_assert should be merely a warning, not a full OOPS. I
think that, if rcu_lockdep_assert hangs, then we should fix that
rather than avoiding debugging checks.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/