Re: [PATCH] mvneta: add forgotten initialization of autonegotiation bits

[David Miller]

From: Stas Sergeev <stsp@xxxxxxx>
Date: Thu, 18 Jun 2015 18:36:03 +0300

> 
> The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state
> signaling")
> changed mvneta_adjust_link() so that it does not clear the auto-negotiation
> bits in MVNETA_GMAC_AUTONEG_CONFIG register. This was necessary for
> auto-negotiation mode to work.
> Unfortunately I haven't checked if these bits are ever initialized.
> It appears they are not.
> This patch adds the missing initialization of the auto-negotiation bits
> in the MVNETA_GMAC_AUTONEG_CONFIG register.
> It fixes the following regression:
> https://www.mail-archive.com/netdev@xxxxxxxxxxxxxxx/msg67928.html
> 
> Since the patch was tested to fix a regression, it should be applied to
> stable tree.
> 
> Tested-by: Arnaud Ebalard <arno@xxxxxxxxxxxx>
> 
> CC: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>
> CC: Florian Fainelli <f.fainelli@xxxxxxxxx>
> CC: netdev@xxxxxxxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
> CC: stable@xxxxxxxxxxxxxxx
> 
> Signed-off-by: Stas Sergeev <stsp@xxxxxxxxxxxxxxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/