Re: [PATCH 0/1] mm: move ->mremap() from file_operations to vm_operations_struct
From: Andy Lutomirski
Date: Tue Jun 23 2015 - 17:00:04 EST
On Tue, Jun 23, 2015 at 11:02 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> On 06/22, Andy Lutomirski wrote:
>> On Mon, Jun 22, 2015 at 5:47 PM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>> > I never understood why ->mremap() lives in file_operations, not in
>> > vm_operations_struct. To me vma->vm_file->f_op in move_vma() just
>> > looks strange, vma->vm_ops->mremap(new_vma) looks "obviously better".
>> > And afaics more useful. CRIU remaps vdso, but this does not update
>> > mm->context.vdso. OK, probably this does not matter currently, CRIU
>> > can't c/r the compat tasks, and 64-bit apps do not use context.vdso.
>> > Afaics. Still, I think we might want to have special_mapping_remap()
>> > and we can't do this because ->vm_file == NULL.
>> I would like this. Then I could clean up and resubmit my patch to
>> keep context.vdso up to date.
> Cough... where can I find this patch ? ;)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/