Re: [v4 01/16] KVM: Extend struct pi_desc for VT-d Posted-Interrupts

From: Paolo Bonzini
Date: Wed Jun 24 2015 - 04:46:23 EST




On 24/06/2015 07:42, Wu, Feng wrote:
> Do you mean we don't use bitfields at all, or the following format is
> acceptable, in which, we use bitfileds as less as possible?

> union {
> struct
> {
> u16 on : 1, /* bit 256 - Outstanding Notification */
> sn : 1, /* bit 257 - Suppress Notification */
> rsvd_1 : 14; /* bit 271:258 - Reserved */
> u8 nv; /* bit 279:272 - Notification Vector */
> u8 rsvd_2; /* bit 287:280 - Reserved */
> u32 ndst; /* bit 319:288 - Notification Destination */
> };
> u64 control;

This is okay.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/