Re: [RFC][PATCH 12/13] stop_machine: Remove lglock

From: Peter Zijlstra
Date: Wed Jun 24 2015 - 05:31:27 EST


On Wed, Jun 24, 2015 at 10:32:57AM +0200, Peter Zijlstra wrote:
> + s = atomic_long_read(&rsp->expedited_done);
> + if (ULONG_CMP_GE((ulong)s, (ulong)snap)) {
> + /* ensure test happens before caller kfree */
> + smp_mb__before_atomic(); /* ^^^ */

FWIW isn't that guaranteed by the control dep?

> + atomic_long_inc(&rsp->expedited_workdone1);
> + goto unlock;
> + }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/