Re: [GIT PULL] f2fs updates for v4.2

From: Jaegeuk Kim
Date: Thu Jun 25 2015 - 02:48:43 EST


On Thu, Jun 25, 2015 at 07:32:36AM +0100, Al Viro wrote:
> On Wed, Jun 24, 2015 at 10:50:10PM -0700, Jaegeuk Kim wrote:
>
> > Right, I missed merging the fix-up patch in linux-next into my pull-request.
> > At a glance, I think there is no problem; except 80 column width, though.
> >
> > Also, agreed that I need to take a look at deleting the dentry to deal with that
> > failure case.
>
> Why not set the symlink up first and create a directory entry only
> if that succeeds? Looks like it's less work that way...

Cause f2fs_add_link initializes some on-disk inode structures to be used when
writing data.

Maybe simply call f2fs_unlink?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/