Re: [PATCH] SCSI-wd33c93: Deletion of a check before the function call "wd33c93_setup"

From: Dan Carpenter
Date: Thu Jun 25 2015 - 05:55:43 EST


On Wed, Jun 24, 2015 at 05:33:50PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 24 Jun 2015 17:15:17 +0200
>
> The wd33c93_setup() function performs also input parameter validation.
> Thus the test around the call is not needed.
>

Guys, you should be aware that Markus auto generates his patches and he
doesn't even do a cursory review.

"I find it acceptable that some of my update suggestions do not fit
to your quality expectations at the moment." -- Markus Elfring
(https://lkml.org/lkml/2015/1/22/446)

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/