Re: [PATCH v3 16/19] staging: sm750fb: fix brace placement

From: Dan Carpenter
Date: Thu Jun 25 2015 - 16:31:55 EST


On Thu, Jun 25, 2015 at 08:49:30AM -0700, Juston Li wrote:
> I placed it above the else to make it consistent with the if statement with
> similar comment that the else corresponds to:
>
> /* Set the primary display control */
> - if (!ctrl)+ if (!ctrl) {

Once you add the else statement, then that kind of doesn't make sense.
Sudip is right. It should be:

} else {
/* commentary about else side */

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/