Re: [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

From: Gabriele Mazzotta
Date: Sat Jun 27 2015 - 09:22:17 EST


On Saturday 27 June 2015 15:01:34 Pali Rohár wrote:
> On Saturday 27 June 2015 14:55:40 Gabriele Mazzotta wrote:
> > On Saturday 27 June 2015 14:47:16 Pali Rohár wrote:
> > > On Saturday 27 June 2015 13:34:30 Gabriele Mazzotta wrote:
> > > > Hi Pali,
> > > >
> > > > I've just noticed an issue with this patch. See the comment here
> > > > below.
> > > >
> > > > Gabriele
> > > >
> > > > On Wednesday 29 April 2015 13:41:26 Pali Rohár wrote:
> > > > > @@ -750,8 +777,8 @@ static int __init i8k_init_hwmon(void)
> > > > >
> > > > > if (err >= 0)
> > > > >
> > > > > i8k_hwmon_flags |= I8K_HWMON_HAVE_FAN2;
> > > > >
> > > > > - i8k_hwmon_dev = hwmon_device_register_with_groups(NULL,
> > > > > "i8k", NULL, - i8k_groups);
> > > > > + i8k_hwmon_dev = hwmon_device_register_with_groups(NULL,
> > > > > "dell-smm", + NULL, i8k_groups);
> > > >
> > > > dell-smm is not a valid name, see
> > > > hwmon_device_register_with_groups() for more info (dash not
> > > > allowed). Because of this, the driver can't be loaded.
> > >
> > > How it is possible? It worked fine on my tested dell machine...
> > >
> > > And now I see, I probably tested this change with older kernel
> > > version (ubuntu/3.13) which did not have that check for invalid
> > > characters...
> > >
> > > Renaming dell-smm to dell_smm should fix this problem, right?
> >
> > Yes, everything works just fine with the underscore.
>
> Ok, will you send patch for this small fix?

OK, I'll do it shortly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/