Re: [PATCH] thermal: consistently use int for temperatures

[Lukasz Majewski]

Hi Sascha,

> The thermal code uses int, long and unsigned long for temperatures
> in different places.
> 
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0ÂC. This will
> probably immediately shut the machine down due to overtemperature if
> started below 0ÂC.
> 
> 'long' is 64bit on several architectures. This is not needed since
> INT_MAX ÂmC is above the melting point of all known materials.
> 
> Consistently use a plain 'int' for temperatures throughout the
> thermal code and the drivers. This only changes the places in the
> drivers where the temperature is passed around as pointer, when
> drivers internally use another type this is not changed.
> 
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>

Sascha, thanks for this cleanup work. 

Reviewed-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/