Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no broadcast device available

From: Thomas Gleixner
Date: Tue Jul 07 2015 - 07:56:13 EST


On Tue, 7 Jul 2015, Sudeep Holla wrote:
> Yes I tested this patch for all the combinations I had mentioned in my
> earlier email. Everything works as expected. Thanks a lot for the
> patience. Please feel free to add:
>
> Tested-by: Sudeep Holla <sudeep.holla@xxxxxxx>
>
> > {
> > Index: tip/kernel/time/tick-broadcast.c
> > ===================================================================
> > --- tip.orig/kernel/time/tick-broadcast.c
> > +++ tip/kernel/time/tick-broadcast.c
>
> > @@ -938,6 +972,16 @@ bool tick_broadcast_oneshot_available(vo
> > return bc ? bc->features & CLOCK_EVT_FEAT_ONESHOT : false;
> > }
> >
> > +#else
> > +int __tick_broadcast_oneshot_control(enum tick_broadcast_state state)
> > +{
> > + struct clock_event_device *bc = tick_broadcast_device.evtdev;
> > +
> > + if (!bc || (bc->features & CLOCK_EVT_FEAT_HRTIMER)
>
> missing ')' at the end in the above statement

Indeed. Did not compile that combo.

Thanks a lot for testing all the combos!!!

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/