Re: [PATCH] 3c59x: Fix shared IRQ handling

From: David Miller
Date: Thu Jul 09 2015 - 02:38:00 EST


From: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
Date: Tue, 7 Jul 2015 20:48:55 +0200

> As its first order of business, boomerang_interrupt() checks whether
> the device really has any pending interrupts. If it does not,
> it does nothing and returns, but it still returns IRQ_HANDLED.
>
> This is wrong: interrupt was not handled, IRQ handlers of other
> devices sharing this IRQ line need to be called.
>
> vortex_interrupt() has it right: it returns IRQ_NONE in this case
> via IRQ_RETVAL(0).
>
> Do the same in boomerang_interrupt().
>
> Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx>

Looks good, applied, thanks Denys.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/