Re: [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC

From: Wolfram Sang
Date: Thu Jul 09 2015 - 16:09:39 EST


Hi,

thanks for the submission!

> +#define CDNS_I2C_BROKEN_HOLD_BIT 0x00000001

BIT(0) maybe?

> +static const struct cdns_platform_data r1p10_i2c_def = {
> + .quirks = CDNS_I2C_BROKEN_HOLD_BIT, };

Closing '}' should be on seperate line.

And what Mark said.

Other than that, looks okay I'd say.

Attachment: signature.asc
Description: Digital signature