Re: [PATCH 3/4] irqchip: Add documentation for the bcm2836 interrupt controller.

From: Eric Anholt
Date: Sat Jul 11 2015 - 02:08:56 EST


Stephen Warren <swarren@xxxxxxxxxxxxx> writes:

> On 07/07/2015 03:13 PM, Eric Anholt wrote:
>> This is a new per-cpu root interrupt controller on the Raspberry Pi 2,
>> which will chain to the bcm2835 interrupt controller for peripheral
>> interrupts.
>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt
>
>> +local_intc: local_intc {
>
>> + interrupt-parent = <&local_intc>;
>
> I think that property shouldn't be there?

If you don't have it there, the core finds the interrupt-parent in the
parent node, and waits for that one before initializing (which is in
turn waiting for us). Note that for original 2835, you're finding the
parent node as well.

Attachment: signature.asc
Description: PGP signature