Re: [PATCH v2 3/3] RTC: switch to using is_visible() to control sysfs attributes

From: Krzysztof Kozlowski
Date: Fri Jul 24 2015 - 00:10:15 EST


On 24.07.2015 08:01, Dmitry Torokhov wrote:
> Instead of creating wakealarm attribute manually, after the device has been
> registered, let's rely on facilities provided by the attribute groups to
> control which attributes are visible and which are not. This allows to to
> create all needed attributes at once, at the same time that we register RTC
> class device.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
> drivers/rtc/class.c | 4 +---
> drivers/rtc/rtc-core.h | 19 +++-------------
> drivers/rtc/rtc-sysfs.c | 59 +++++++++++++++++++++++++------------------------
> 3 files changed, 34 insertions(+), 48 deletions(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/