Re: [PATCH 5/5] x86/asm/entry/32: Simplify FLAGS_NT clearing in SYSENTER32 code.

From: Andy Lutomirski
Date: Mon Jul 27 2015 - 18:40:25 EST


On Mon, Jul 27, 2015 at 1:33 PM, Denys Vlasenko <dvlasenk@xxxxxxxxxx> wrote:
> "sysenter_fix_flags" detour does not need to be convoluted anymore,
> straigten it up. However, we still use this:
>
> jnz 2f
> jmp sysenter_jumps_here
> 2: ...
>
> instead of this:
>
> jz sysenter_jumps_here
> ...
>
> because "cold" conditional forward branch is predicted not taken
> by most CPUs - exactly what we want. Latter version would get it wrong.
>
> Reinstate "why we use SYSRETL instead of SYSEXIT" comment.
>

Acked-by: Andy Lutomirski <luto@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/