RE: [PATCH net 1/2] r8152: add pre_reset and post_reset

From: Hayes Wang
Date: Tue Jul 28 2015 - 06:29:25 EST


Oliver Neukum [mailto:oneukum@xxxxxxxx]
> Sent: Tuesday, July 28, 2015 4:53 PM
[...]
> > + return 0;
> > +
> > + netdev = tp->netdev;
> > + if (!netif_running(netdev))
> > + return 0;
> > +
> > + ret = usb_autopm_get_interface(intf);
> > + if (ret < 0)
> > + return ret;
>
> What sense does this make?
>
[...]
> > + return 0;
> > +
> > + netdev = tp->netdev;
> > + if (!netif_running(netdev))
> > + return 0;
> > +
> > + ret = usb_autopm_get_interface(intf);
>
> The device will be awake.

I don't sure if the device would be in runtimesuspend, so I wake it up by myself.
I think you mean I don't have to do this. I would remove them and resend the
patch. Thanks.

Best Regards,
Hayes