RE: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

[Shenwei Wang]

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx]
> Sent: 2015年7月28日 9:39
> To: Wang Shenwei-B38339
> Cc: shawn.guo@xxxxxxxxxx; tglx@xxxxxxxxxxxxx; jason@xxxxxxxxxxxxxx; Huang
> Yongcai-B20788; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup
> sources
> 
> On Tue, Jul 28, 2015 at 02:27:42PM +0000, Shenwei Wang wrote:
> > > > +static int gpcv2_wakeup_source_save(void) {
> > > > +	struct imx_gpcv2_irq *cd;
> > >
> > > We generally name variables in an abbrev of the types to make them
> > > intuitive.  I tried hard to map "cd" to "imx_gpcv2_irq" and failed.
> > > Can you help me on that?
> >
> > CD is the abbreviation of chip data which is a member of irq_data.
> 
> You are defining a variable of type imx_gpcv2_irq, neither chip_data nor irq_data.

Imx_gpcv2_irq itself is the chip_data of irq_data.

> > > > +void ca7_cpu_resume(void);
> > > > +void imx7_suspend(void __iomem *ocram_vbase);
> > >
> > > Why do these declarations need to be in this header?
> >
> > Just to resolve the compile errors.
> 
> Wrong solution.  They belong to some header in arch/arm/mach-imx not
> include/soc/imx, as there is no code outside arch/arm/mach-imx needs these
> declaration.

It is a little ugly. I was thinking to have a gpcv2.h header file, so put them there. 
But as the header file is going to be removed, I am considering to move it to 
common.h. Although it seems not beautiful too.

Thanks,
Shenwei

> Shawn