Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for additional bq27xxx family devices

From: Pavel Machek
Date: Sun Aug 02 2015 - 03:38:59 EST



> +#define INVALID_REG_ADDR 0xff

> +static u8 bq27000_regs[] = {
> + 0x00, /* CONTROL */
> + 0x06, /* TEMP */
> + 0xff, /* INT TEMP - NA*/

I'd use the INVALID_REG_ADDR macro here.. Makes it more clear what is
going on (and you may change it to -1 in future, for example).

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/