RE: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA FMan

[Liberman Igal]

Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, July 30, 2015 11:00 PM
> To: Liberman Igal-B31950
> Cc: devicetree@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx; Bucur
> Madalin-Cristian-B32716; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for
> the FSL QorIQ DPAA FMan
> 
> On Thu, 2015-07-30 at 07:32 +0300, Igal.Liberman wrote:
> > +fman0:  fman@400000{
> > +     #address-cells = <1>;
> > +     #size-cells = <1>;
> > +     cell-index = <0>;
> > +     compatible = "fsl,fman";
> > +     ranges = <0 0x400000 0x100000>;
> > +     reg = <0x400000 0x100000>;
> > +     interrupts = <96 2 0 0>, <16 2 1 1>;
> > +     clocks = <&clockgen 3 0>;
> > +     clock-names = "fm0clk";
> 
> clock-names should be "fmanclk" as per the binding.  And why would you
> want the driver to have to encode the fman index into the name in order to
> look the clock up by name?
> 

Well, yes, this should be "fmanclk". The driver doesn't need to know the index.
I'll fix that and re-submit.

Igal.

> -Scott

N‹§²æ¸›yú²X¬¶ÇvØ–)Þ{.nlj·¥Š{±‘êX§¶›¡Ü}©ž²ÆzÚj:+v‰¨¾«‘êZ+€Êzf£¢·hšˆ§~†­†Ûÿû®w¥¢¸?™¨è&¢)ßf”ùy§m…á«a¶Úÿ0¶ìå