Re: [PATCH -v2 6/8] jump_label: Add a new static_key interface

From: Steven Rostedt
Date: Mon Aug 03 2015 - 17:58:06 EST


On Mon, 3 Aug 2015 22:00:02 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Mon, Aug 03, 2015 at 03:28:10PM -0400, Steven Rostedt wrote:
> > Technically, one can think: "activate the branch", but we are
> > activating not the branch, but the jump label itself.
>
> No you are enabling the branch, you're making the branch body active.

By making the statement "true".

Otherwise we could just have:

static_branch_likely(&blah) {
[..]
}

And remove the "if".

Then it would make sense to enable or disable it.

>
> There is no enable/disable/true/false for the jump label, only NOP or
> JUMP, and either can result in an active branch body.

That's implementation details, not a general concept that users will
need to know about.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/