Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call.

[Tomasz Nowicki]

On 05.08.2015 15:48, Rafael J. Wysocki wrote:
> On Tuesday, August 04, 2015 04:01:59 PM David Daney wrote:
> > From: Tomasz Nowicki <tomasz.nowicki@xxxxxxxxxx>
> >
> > Fixes the following build error when building drivers as modules:
> >
> >   ERROR: "acpi_dev_prop_read_single" [drivers/net/phy/mdio-octeon.ko] undefined!
> >   ERROR: "acpi_dev_prop_read_single" [drivers/net/ethernet/cavium/thunder/thunder_bgx.ko] undefined!
>
> Can you please tell me why the drivers in question use that function
> directly, although they aren't supposed to?
>
> Clearly, their authors had not tried to build them as modules or they
> would have noticed the problem at the development stage already.
>
> What would be wrong with using the generic device properties API instead?
Yes, you are right. We should use:
int device_property_read_u64_array(struct device *dev, const char 
*propname, u64 *val, size_t nval);

Regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/