Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3 buttons

[Joe Perches]

On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
> On Thu, Aug 06, 2015 at 11:20:44AM +0000, Chen, Yu C wrote:
[]
> > Is it ok to keep these codes and add comments like:

It's your code Yu, do whatever you think appropriate.

> > /*
> >  * When a button(power button/volume button/home button) is 
> >  * pressed down or released, different ACPI notification codes 
> >  * will be generated. We can distinguish different event code 
> >  * and value of buttons by these notification codes, then pass
> >  * (EV_KEY, event code(key_code), value(pressed)) to input layer.
> >  */
> 
> The commentary is useful regardless. However, I suspect Joe was
> referring to the approach pairing the PRESS and RELEASE cases?
> 

True.

btw Darren, your computer's email time setting seems off.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/