Re: [PATCH v3 06/18] regulator: core: Probe regulators on demand

From: Mark Brown
Date: Fri Aug 07 2015 - 08:09:32 EST


On Thu, Aug 06, 2015 at 04:11:43PM +0200, Tomeu Vizoso wrote:

> When looking up a regulator through its OF node, probe it if it hasn't
> already.
>
> The goal is to reduce deferred probes to a minimum, as it makes it very
> cumbersome to find out why a device failed to probe, and can introduce
> very big delays in when a critical device is probed.

Still the same problem as we had before with this stuff, why is this DT
only?

> #include <linux/regulator/consumer.h>
> @@ -1336,6 +1337,7 @@ static struct regulator_dev *regulator_dev_lookup(struct device *dev,
> if (dev && dev->of_node) {
> node = of_get_regulator(dev, supply);
> if (node) {
> + of_platform_probe(node);

And why the assumption that this is a platform device?

Attachment: signature.asc
Description: Digital signature