Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios

From: Mike Snitzer
Date: Mon Aug 10 2015 - 11:02:28 EST

On Sun, Aug 09 2015 at 3:18am -0400,
Ming Lin <mlin@xxxxxxxxxx> wrote:

> On Sun, 2015-08-09 at 00:01 -0700, Christoph Hellwig wrote:
> > On Sat, Aug 08, 2015 at 11:55:47PM -0700, Ming Lin wrote:
> > > Will change it to MAX_BIO_SECTORS.
> > > May I add your ACK?
> >
> > Yes, please go ahead.
> Thanks. I'll send a new version of the series once device-mapper guy
> acks.
> Hi Mike,
> I have updated my tree. Could you pull and re-test?
> The 2 thin-provisioning tests passed.

I've merged your latest branch with my dm-4.3 branch, I had one conflict
in the merge due to the dm_merge_bvec() change from 4.2-rc6 (no
surprise). I've published the result here:

It passes the device-mapper-test-suite's 'thin-provisioning' tests.

> Hope I can have your ACK soon.

Shouldn't we also be using MAX_BIO_SECTORS in blkdev_issue_write_same
(instead of UINT_MAX >> 9)?

Aside from that, I'm in favor of seeing this late bio splitting patchset
finally land upstream (hopefully in time for the 4.3 merge, Jens?):

Acked-by: Mike Snitzer <snitzer@xxxxxxxxxx>

p.s. I'll be working with Joe Thornber on optimizing DM (particularly
dm-thinp and dm-cache) once this patchset is included upstream. You'll
see I've already added a couple WIP dm-thinp patches ontop.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at