RE: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode

From: Luck, Tony
Date: Tue Aug 11 2015 - 14:52:26 EST


> Well, ok, but do it differently, please: rename
> cmci_storm_disable_banks() to cmci_storm_switch_banks(bool on) which
> turns them on and off. Unless Tony has a better suggestion...

I like the boolean argument ... but not the "switch_banks" name. It sounds more
like we are juggling between banks, rather than setting a switch/flag in a bank.

How does "cmci_storm_set_cmci(bool on)" sound? Too many "cmci" in one name?

-Tony