Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode

From: Xie XiuQi
Date: Tue Aug 11 2015 - 22:08:47 EST

On 2015/8/12 2:52, Luck, Tony wrote:
Well, ok, but do it differently, please: rename
cmci_storm_disable_banks() to cmci_storm_switch_banks(bool on) which
turns them on and off. Unless Tony has a better suggestion...

I like the boolean argument ... but not the "switch_banks" name. It sounds more
like we are juggling between banks, rather than setting a switch/flag in a bank.

How does "cmci_storm_set_cmci(bool on)" sound? Too many "cmci" in one name?

Thanks, I'll use this name.

Xie XiuQi


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at