Re: [PATCH v8 3/4] drivers: nvmem: Add Vybrid OCOTP support

[Srinivas Kandagatla]

On 12/08/15 12:32, maitysanchayan@xxxxxxxxx wrote:
> Hello,
>
> On 15-08-12 11:41:55, Srinivas Kandagatla wrote:
> > >Hi Sanchayan,
> > >
> > >Please run checkpatch before you send the patch next time.
> > >Look at Documentation/SubmittingPatches for more details.
> > >
> > >WARNING: line over 80 characters
> > >#225: FILE: drivers/nvmem/vf610-ocotp.c:174:
> > >+			ret = vf610_ocotp_wait_busy(ocotp->base + OCOTP_CTRL_REG);
> > >
> > >WARNING: line over 80 characters
> > >#237: FILE: drivers/nvmem/vf610-ocotp.c:186:
> > >+			ret = vf610_ocotp_wait_busy(ocotp->base + OCOTP_CTRL_REG);
> > >
> > >WARNING: line over 80 characters
> > >#244: FILE: drivers/nvmem/vf610-ocotp.c:193:
> > >+				writel(OCOTP_CTRL_ERROR, ocotp->base + OCOTP_CTRL_CLR);
> > >
> I had. However splitting these lines seemed odd. Will split and fix.
Just get the base to a local variable, which should make it look neat 
and this will avoid de-referencing the octop in the all the time in loop.

--srini
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/