Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic
From: Simon Horman
Date: Thu Aug 13 2015 - 03:57:55 EST
On Thu, Aug 13, 2015 at 01:53:45PM +0800, Baoquan He wrote:
> On 08/13/15 at 09:55am, Simon Horman wrote:
> > On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote:
> > > Transforming PFN(Page Frame Number) to struct page is never failure, so
> > > we can simplify the code logic to do the image->control_page assignment
> > > directly in the loop, and remove the unnecessary conditional judgement.
> > >
> > > Signed-off-by: Minfei Huang <mnfhuang@xxxxxxxxx>
> > > Acked-by: Dave Young <dyoung@xxxxxxxxxx>
> > > Acked-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
> > Andrew, could you consider picking this up.
> > It seems to have been sufficiently reviewed, acked, etc...
> I saw this has been in linux-next tree.
Excellent, sorry for the noise.
> commit b90b6ef0f152ef42fe66ce5c9ccf2783ea84fa69
> Author: Minfei Huang <mnfhuang@xxxxxxxxx>
> Date: Thu Jul 30 09:56:18 2015 +1000
> kexec: remove unnecessary test in kimage_alloc_crash_control_pages()
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/