Re: [PATCH 15/15] hmm/dummy: dummy driver for testing and showcasing the HMM API

From: Sylvain Jeaugey
Date: Thu Aug 13 2015 - 09:46:03 EST

Hi Jerome,

I get a compilation error when building the hmm_dummy module (undefined
function hmm_pte_test_select).

On Fri, 17 Jul 2015, Jérôme Glisse wrote:
> +static int dummy_mirror_pt_populate(struct hmm_mirror *mirror,
> + struct hmm_event *event)
> [ snip ]
> + if (!mpte || !hmm_pte_test_valid_pfn(mpte) ||
> + !hmm_pte_test_select(mpte)) {
>From what I understand, the select flag no longer exists in HMM PTE,
hence hmm_pte_test_select is missing.
Removing this sanity check, the module compiles and loads correctly.

Aside from that problem, is there a userspace test available which
interfaces with the dummy module ?